Feed aggregator

Incorrect CSS class for form element wrappers

Arthur's Issue posts - 30 min 43 sec ago

This is a bug related to issue #43493: FAPI: Add name/type as CSS class for form elements.

If a form element name has a embedded space, then the resulting CSS class would be incorrect for the form element wrapper.
This can be seen on the permissions page when the book module is enabled, the "Create new books" permission's checkboxes are pushed to the right, out of the column (see attached image).
This is due to the class being "form-item form-item-checkbox 1-create new books-wrapper" instead of something like "form-item form-item-checkbox 1-create-new-books-wrapper"

The attached patch adds a space to dash conversion to the special character conversion list for the CSS class string.

Categories: Drupal.org Feed

Incorrect CSS class for form element wrappers

Doug's Issue posts - 30 min 43 sec ago

This is a bug related to issue #43493: FAPI: Add name/type as CSS class for form elements.

If a form element name has a embedded space, then the resulting CSS class would be incorrect for the form element wrapper.
This can be seen on the permissions page when the book module is enabled, the "Create new books" permission's checkboxes are pushed to the right, out of the column (see attached image).
This is due to the class being "form-item form-item-checkbox 1-create new books-wrapper" instead of something like "form-item form-item-checkbox 1-create-new-books-wrapper"

The attached patch adds a space to dash conversion to the special character conversion list for the CSS class string.

Categories: Drupal.org Feed

Incorrect CSS class for form element wrappers

Owen's Issue posts - 30 min 43 sec ago

This is a bug related to issue #43493: FAPI: Add name/type as CSS class for form elements.

If a form element name has a embedded space, then the resulting CSS class would be incorrect for the form element wrapper.
This can be seen on the permissions page when the book module is enabled, the "Create new books" permission's checkboxes are pushed to the right, out of the column (see attached image).
This is due to the class being "form-item form-item-checkbox 1-create new books-wrapper" instead of something like "form-item form-item-checkbox 1-create-new-books-wrapper"

The attached patch adds a space to dash conversion to the special character conversion list for the CSS class string.

Categories: Drupal.org Feed

Field info passed to theme functions field only, not field/content type

Arthur's Issue posts - 37 min 40 sec ago

Best I can tell at least in one field handler the information passed to the theme function is the field information general, not the specific one for the content type.

For example imagefield using the per content type field information for choicing what default image to display, resulting in all to result in whatever the main field default image is instead of content type based.

Here's my comment in the issue in imagefield issue about it (later comment with exact file name of handler). http://drupal.org/node/460996#comment-1740776

(Sorry about post twice so closely together :/).

Using latest 2.x stable of cck.

Categories: Drupal.org Feed

Field info passed to theme functions field only, not field/content type

Doug's Issue posts - 37 min 40 sec ago

Best I can tell at least in one field handler the information passed to the theme function is the field information general, not the specific one for the content type.

For example imagefield using the per content type field information for choicing what default image to display, resulting in all to result in whatever the main field default image is instead of content type based.

Here's my comment in the issue in imagefield issue about it (later comment with exact file name of handler). http://drupal.org/node/460996#comment-1740776

(Sorry about post twice so closely together :/).

Using latest 2.x stable of cck.

Categories: Drupal.org Feed

Field info passed to theme functions field only, not field/content type

Owen's Issue posts - 37 min 40 sec ago

Best I can tell at least in one field handler the information passed to the theme function is the field information general, not the specific one for the content type.

For example imagefield using the per content type field information for choicing what default image to display, resulting in all to result in whatever the main field default image is instead of content type based.

Here's my comment in the issue in imagefield issue about it (later comment with exact file name of handler). http://drupal.org/node/460996#comment-1740776

(Sorry about post twice so closely together :/).

Using latest 2.x stable of cck.

Categories: Drupal.org Feed

making the home link optional

Arthur's Issue posts - 49 min 48 sec ago

Hi - thanks for this useful module.

This might be a feature request or it might just be a request for info.

I wanted to have a breadcrumb which didn't include the initial "home" link. I looked around and couldn't see a "proper" way to do this - correct me if I'm wrong. (But I am using 6.x-1.4 and maybe it's in 6.x-2.x-dev under "pages at arbitrary paths", is it??)

Instead I tried commenting out line 55 of custom_breadcrumbs.module, i.e. where it initialises $trail:

$trail = array(l(t('Home'), ''));

This seemed to do the trick. But obviously hacking is bad and wrong :-)

If something similar isn't already in the new dev iteration (or if it is, but in a more complicated way) then please could we have a ticky box above the "Titles" and "Paths" fields, for "auto-include home page link as first crumb"? or something like that?

This could either be global (in which case you'd have to put in your own home page link if you wanted it part of the time) or specific to each customisation entry.

Thanks for considering this, &/or for any other tips on best way to accomplish the same result...

Jennifer

Categories: Drupal.org Feed

making the home link optional

Doug's Issue posts - 49 min 48 sec ago

Hi - thanks for this useful module.

This might be a feature request or it might just be a request for info.

I wanted to have a breadcrumb which didn't include the initial "home" link. I looked around and couldn't see a "proper" way to do this - correct me if I'm wrong. (But I am using 6.x-1.4 and maybe it's in 6.x-2.x-dev under "pages at arbitrary paths", is it??)

Instead I tried commenting out line 55 of custom_breadcrumbs.module, i.e. where it initialises $trail:

$trail = array(l(t('Home'), ''));

This seemed to do the trick. But obviously hacking is bad and wrong :-)

If something similar isn't already in the new dev iteration (or if it is, but in a more complicated way) then please could we have a ticky box above the "Titles" and "Paths" fields, for "auto-include home page link as first crumb"? or something like that?

This could either be global (in which case you'd have to put in your own home page link if you wanted it part of the time) or specific to each customisation entry.

Thanks for considering this, &/or for any other tips on best way to accomplish the same result...

Jennifer

Categories: Drupal.org Feed

making the home link optional

Owen's Issue posts - 49 min 48 sec ago

Hi - thanks for this useful module.

This might be a feature request or it might just be a request for info.

I wanted to have a breadcrumb which didn't include the initial "home" link. I looked around and couldn't see a "proper" way to do this - correct me if I'm wrong. (But I am using 6.x-1.4 and maybe it's in 6.x-2.x-dev under "pages at arbitrary paths", is it??)

Instead I tried commenting out line 55 of custom_breadcrumbs.module, i.e. where it initialises $trail:

$trail = array(l(t('Home'), ''));

This seemed to do the trick. But obviously hacking is bad and wrong :-)

If something similar isn't already in the new dev iteration (or if it is, but in a more complicated way) then please could we have a ticky box above the "Titles" and "Paths" fields, for "auto-include home page link as first crumb"? or something like that?

This could either be global (in which case you'd have to put in your own home page link if you wanted it part of the time) or specific to each customisation entry.

Thanks for considering this, &/or for any other tips on best way to accomplish the same result...

Jennifer

Categories: Drupal.org Feed

Option to retain invalid value on edit

Arthur's Issue posts - 52 min 48 sec ago

Weird feature request, but basically, I'd like an option to retain invalid value on edits if they'd been valid (ie match the old value).

The reasoning behind it is the ability to have 1 to 1 relationship for nodes via nodereference.

I have ct2 that with a node reference to ct1. I have an advanced view suppling NIDs to node reference. The view excludes all ct1s that already have a node reference to ct2 (given certain conditions).

The problem is not on creation; that works fine; but later editing and trying to resave the node it will always fail validation since the view no longer has it cause the node has it. Can't figure out a way around this in views :(.

For a real example, I'm making an online gear tracker for a mmorpg I play, and ct1 is a "gear" while ct2 is a "borrowing record", and well, a gear can't be borrowed more than once at the same time (using workflow for borrow, lost, returned states). And yeah, can't edit the borrowed instantaneous until I mark as returned.

So basically, an option to retain old values even if invalid. Is this a useful or valid feature request? If not I'll just do a workaround specific to myself. I hate hacking cck though, annoying when upgrading.

Categories: Drupal.org Feed

Option to retain invalid value on edit

Doug's Issue posts - 52 min 48 sec ago

Weird feature request, but basically, I'd like an option to retain invalid value on edits if they'd been valid (ie match the old value).

The reasoning behind it is the ability to have 1 to 1 relationship for nodes via nodereference.

I have ct2 that with a node reference to ct1. I have an advanced view suppling NIDs to node reference. The view excludes all ct1s that already have a node reference to ct2 (given certain conditions).

The problem is not on creation; that works fine; but later editing and trying to resave the node it will always fail validation since the view no longer has it cause the node has it. Can't figure out a way around this in views :(.

For a real example, I'm making an online gear tracker for a mmorpg I play, and ct1 is a "gear" while ct2 is a "borrowing record", and well, a gear can't be borrowed more than once at the same time (using workflow for borrow, lost, returned states). And yeah, can't edit the borrowed instantaneous until I mark as returned.

So basically, an option to retain old values even if invalid. Is this a useful or valid feature request? If not I'll just do a workaround specific to myself. I hate hacking cck though, annoying when upgrading.

Categories: Drupal.org Feed

Option to retain invalid value on edit

Owen's Issue posts - 52 min 48 sec ago

Weird feature request, but basically, I'd like an option to retain invalid value on edits if they'd been valid (ie match the old value).

The reasoning behind it is the ability to have 1 to 1 relationship for nodes via nodereference.

I have ct2 that with a node reference to ct1. I have an advanced view suppling NIDs to node reference. The view excludes all ct1s that already have a node reference to ct2 (given certain conditions).

The problem is not on creation; that works fine; but later editing and trying to resave the node it will always fail validation since the view no longer has it cause the node has it. Can't figure out a way around this in views :(.

For a real example, I'm making an online gear tracker for a mmorpg I play, and ct1 is a "gear" while ct2 is a "borrowing record", and well, a gear can't be borrowed more than once at the same time (using workflow for borrow, lost, returned states). And yeah, can't edit the borrowed instantaneous until I mark as returned.

So basically, an option to retain old values even if invalid. Is this a useful or valid feature request? If not I'll just do a workaround specific to myself. I hate hacking cck though, annoying when upgrading.

Categories: Drupal.org Feed

Page Fromatting for HTML Image with links

Arthur's Issue posts - 54 min 4 sec ago

Note sure if this is a Marinelli issue or just a 'Page' formatting issue- (if i should ask this question elsewhere please let me know!)

My welcome page on http://woundup.net/ is supposed to have an Image with hotlinks that i created (see it working correctly here http://woundup.net/microphone.html)

In the page content i created, all the images seem to be working as are the hyperlinks but the formatting is off. I used the source code from the html page and pasted it into body of a 'page' content type (code below). I have PHP enables as input format (and tried it with the other input options as well but that did not fix.)

Any idea of where i am going wrong? I have looked everywhere on the support channels and have not found anything that resolved it. thanks in advance for any pointers!


Categories: Drupal.org Feed

Page Fromatting for HTML Image with links

Doug's Issue posts - 54 min 4 sec ago

Note sure if this is a Marinelli issue or just a 'Page' formatting issue- (if i should ask this question elsewhere please let me know!)

My welcome page on http://woundup.net/ is supposed to have an Image with hotlinks that i created (see it working correctly here http://woundup.net/microphone.html)

In the page content i created, all the images seem to be working as are the hyperlinks but the formatting is off. I used the source code from the html page and pasted it into body of a 'page' content type (code below). I have PHP enables as input format (and tried it with the other input options as well but that did not fix.)

Any idea of where i am going wrong? I have looked everywhere on the support channels and have not found anything that resolved it. thanks in advance for any pointers!


Categories: Drupal.org Feed

Page Fromatting for HTML Image with links

Owen's Issue posts - 54 min 4 sec ago

Note sure if this is a Marinelli issue or just a 'Page' formatting issue- (if i should ask this question elsewhere please let me know!)

My welcome page on http://woundup.net/ is supposed to have an Image with hotlinks that i created (see it working correctly here http://woundup.net/microphone.html)

In the page content i created, all the images seem to be working as are the hyperlinks but the formatting is off. I used the source code from the html page and pasted it into body of a 'page' content type (code below). I have PHP enables as input format (and tried it with the other input options as well but that did not fix.)

Any idea of where i am going wrong? I have looked everywhere on the support channels and have not found anything that resolved it. thanks in advance for any pointers!


Categories: Drupal.org Feed

How to add same filter to seven views?

Arthur's Issue posts - 1 hour 17 min ago

I have seven views for each section of my magazine and i need to filtered them by taxonomy term (e.g. '2334-new issue') how can i do this without changing all of them?

Categories: Drupal.org Feed

How to add same filter to seven views?

Doug's Issue posts - 1 hour 17 min ago

I have seven views for each section of my magazine and i need to filtered them by taxonomy term (e.g. '2334-new issue') how can i do this without changing all of them?

Categories: Drupal.org Feed

How to add same filter to seven views?

Owen's Issue posts - 1 hour 17 min ago

I have seven views for each section of my magazine and i need to filtered them by taxonomy term (e.g. '2334-new issue') how can i do this without changing all of them?

Categories: Drupal.org Feed

Ubercart must not use hook_add_to_cart() - Change to hook_ubercart_add_to_cart() (and namespace any other hooks)

Arthur's Issue posts - 1 hour 27 min ago

The accepted behaviors for contrib modules is that they have to namespace their hooks. Thus, ubercart should be using hook_ubercart_add_to_cart as a hook, not hook_add_to_cart.

There are other carts in Drupal... There are other "add to cart" modules. There are other functions called add_to_cart(). It's important to change all hooks to include the ubercart namespace.

This problem was responsible for #494304: Add to Ubercart Cart creates Amazon Cart error messages in Amazon Store module. Amazon store had an innocent amazon_store_add_to_cart() function, which unfortunately got called when Ubercart did an add to cart.

Thanks,
-Randy

Categories: Drupal.org Feed

Ubercart must not use hook_add_to_cart() - Change to hook_ubercart_add_to_cart() (and namespace any other hooks)

Doug's Issue posts - 1 hour 27 min ago

The accepted behaviors for contrib modules is that they have to namespace their hooks. Thus, ubercart should be using hook_ubercart_add_to_cart as a hook, not hook_add_to_cart.

There are other carts in Drupal... There are other "add to cart" modules. There are other functions called add_to_cart(). It's important to change all hooks to include the ubercart namespace.

This problem was responsible for #494304: Add to Ubercart Cart creates Amazon Cart error messages in Amazon Store module. Amazon store had an innocent amazon_store_add_to_cart() function, which unfortunately got called when Ubercart did an add to cart.

Thanks,
-Randy

Categories: Drupal.org Feed